Reimplemented resource copy using 'plexus.util.DirectorScanner' instead of maven-filtering #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Scanner' instead of maven-filtering In exchange for some extra file management code, this reduces the amount of dependencies used and injected into AsciidoctorMojo. It should also speed up build times since we are doing much less work now to copy resources. * Created model classes for Resources to ensure Mojo descriptors don't leak internals * Remove 'org.apache.maven.shared:maven-filtering' dependency * Bump plexus-utils to v3.3.1 * Remove unnecessary IT 'resource-filtering' since "under-the-hood" filtering is no longer possible
|
First pass implementation based on passing current tests, but I want to do some refactor and create a component for resource management that can be unit tested. |
abelsromero
force-pushed
the
issue-335-remove-maven-filtering
branch
3 times, most recently
from
bf35d10 to
638923c
Compare
* Remove unused encoding from resource processing * Created CopyResourcesProcessor * ResourcesProcessor no longer throws MojoExecutionException
abelsromero
force-pushed
the
issue-335-remove-maven-filtering
branch
from
638923c to
f2cdb1e
Compare
|
Run some tests with a project with 20k resources and the time reduction at the end is marginal. |
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Aug 28, 2022
Leftover from asciidoctor#597
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In exchange for some extra file management code, this reduces the amount of dependencies
used and injected into AsciidoctorMojo. It should also speed up build times since we
are doing much less work now to copy resources.
closes #335
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Are there any alternative ways to implement this?
We could have have just exposed a custom model pojo to avoid leaking filtering. But I think is worth the effort given the simplification of dependencies and code.
Are there any implications of this pull request? Anything a user must know?
No.
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc